chore: allow for skipping HW device selection in the HW onboarding flows (#1210)

Author: szymonmaslowski

.github/shared/build/action.yml

@@ -102,6 +102,10 @@ inputs:
     description: 'Browser target to build for. Options are [firefox | chromium]'
     required: false
     default: 'chromium'
+  E2E_FORCE_TREZOR_PICKED:
+    description: 'Force Trezor emulation'
+    required: false
+    default: 'false'
 runs:
   using: 'composite'
   steps:
@@ -175,4 +179,5 @@ runs:
         SENTRY_ENVIRONMENT: ${{ inputs.SENTRY_ENVIRONMENT }}
         WALLET_POLLING_INTERVAL_IN_SEC: ${{ inputs.WALLET_POLLING_INTERVAL_IN_SEC }}
         BROWSER: ${{ inputs.BROWSER_TARGET }}
+        E2E_FORCE_TREZOR_PICKED: ${{ inputs.E2E_FORCE_TREZOR_PICKED }}
       run: yarn browser build

.github/workflows/e2e-tests-linux-split.yml

@@ -193,6 +193,7 @@ jobs:
           SENTRY_ENVIRONMENT: 'e2e-tests'
           WALLET_POLLING_INTERVAL_IN_SEC: 5
           BROWSER_TARGET: ${{ env.BROWSER }}
+          E2E_FORCE_TREZOR_PICKED: true
 
       - name: Upload build artifact
         if: needs.setup.outputs.build_exists == 'false'

apps/browser-extension-wallet/.env.defaults

@@ -135,3 +135,6 @@ MIN_NUMBER_OF_COSIGNERS=2
 
 # POLLING PAUSE AFTER INACTIVITY
 SESSION_TIMEOUT=120000
+
+# e2e
+E2E_FORCE_TREZOR_PICKED=false

apps/browser-extension-wallet/src/views/browser-view/features/multi-wallet/hardware-wallet/steps/Connect.tsx

@@ -5,6 +5,7 @@ import { TranslationKey } from '@lace/translation';
 import { TFunction } from 'i18next';
 import React, { useCallback, useEffect, useState, VFC } from 'react';
 import { useTranslation } from 'react-i18next';
+import { useLocation } from 'react-router-dom';
 import { useAnalyticsContext } from '@providers';
 import { useHardwareWallet } from '../context';
 import { useWalletOnboarding } from '../../walletOnboardingContext';
@@ -41,13 +42,22 @@ enum DiscoveryState {
   Running = 'Running'
 }
 
+const useE2eForceTrezorPicked = (): USBDevice | null => {
+  const { search } = useLocation();
+  if (process.env.E2E_FORCE_TREZOR_PICKED !== 'true') return null;
+
+  const forceTrezorPicked = new URLSearchParams(search).has('force-trezor-picked');
+  return forceTrezorPicked ? (Wallet.trezorDescriptors[0] as USBDevice) : null;
+};
+
 export const Connect: VFC = () => {
   const { t } = useTranslation();
   const { postHogActions } = useWalletOnboarding();
   const { back, connect, next } = useHardwareWallet();
   const [discoveryState, setDiscoveryState] = useState<DiscoveryState>(DiscoveryState.Requested);
   const [connectionError, setConnectionError] = useState<ConnectionError | null>(null);
   const analytics = useAnalyticsContext();
+  const forcedTrezorUsbDevice = useE2eForceTrezorPicked();
 
   const translations = makeTranslations({ connectionError, t });
 
@@ -64,7 +74,7 @@ export const Connect: VFC = () => {
       setDiscoveryState(DiscoveryState.Running);
       try {
         void analytics.sendEventToPostHog(postHogActions.hardware.CONNECT_HW_VIEW);
-        const usbDevice = await requestHardwareWalletConnection();
+        const usbDevice = forcedTrezorUsbDevice || (await requestHardwareWalletConnection());
         void analytics.sendEventToPostHog(postHogActions.hardware.HW_POPUP_CONNECT_CLICK);
         await connect(usbDevice);
         setDiscoveryState(DiscoveryState.Idle);
@@ -75,7 +85,7 @@ export const Connect: VFC = () => {
         setConnectionError(parseConnectionError(error));
       }
     })();
-  }, [connect, discoveryState, analytics, next, postHogActions.hardware]);
+  }, [connect, discoveryState, analytics, next, postHogActions.hardware, forcedTrezorUsbDevice]);
 
   return (
     <WalletSetupConnectHardwareWalletStepRevamp

packages/cardano/src/wallet/lib/hardware-wallet.ts

@@ -50,7 +50,7 @@ export const ledgerDescriptors = [{ vendorId: ledgerUSBVendorId }];
 
 // eslint-disable-next-line unicorn/number-literal-case
 const trezorModelTProductId = 0x53_c1;
-const trezorDescriptors = TREZOR_USB_DESCRIPTORS.filter(({ productId }) => productId === trezorModelTProductId);
+export const trezorDescriptors = TREZOR_USB_DESCRIPTORS.filter(({ productId }) => productId === trezorModelTProductId);
 export const supportedHwUsbDescriptors = [...ledgerDescriptors, ...trezorDescriptors];
 
 export const connectDeviceRevamped = async (usbDevice: USBDevice): Promise<HardwareWalletConnection> => {