Skip to content

chore: allow for skipping HW device selection in the HW onboarding flows #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

szymonmaslowski
Copy link
Contributor

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

In order to be able to automate HW onboarding/multiwallet flows with the trezor we need to tweak the implementation so a manual action of initial device selection is skipped.

@szymonmaslowski szymonmaslowski requested review from a team as code owners June 6, 2024 11:00
@szymonmaslowski szymonmaslowski requested a review from bslabiak June 6, 2024 11:00
Copy link

sonarqubecloud bot commented Jun 6, 2024

Copy link

github-actions bot commented Jun 6, 2024

Allure Report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 1c2bddb4

passed failed skipped flaky total result
Total 31 0 0 0 31

processReports: ✅ test report for aa41b751

passed failed skipped flaky total result
Total 33 0 4 0 37

@ljagiela ljagiela force-pushed the feat/onboarding-trezor-skip-picker branch from 1c2bddb to 4079de6 Compare April 9, 2025 14:28
@ljagiela ljagiela force-pushed the feat/onboarding-trezor-skip-picker branch from 4079de6 to aa41b75 Compare April 9, 2025 14:31
Copy link

sonarqubecloud bot commented Apr 9, 2025

Copy link
Collaborator

@mchappell mchappell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szymonmaslowski szymonmaslowski merged commit 870d6e8 into main Apr 24, 2025
31 checks passed
@szymonmaslowski szymonmaslowski deleted the feat/onboarding-trezor-skip-picker branch April 24, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants