-
Notifications
You must be signed in to change notification settings - Fork 6
chore: split build files into smaller chunks [LW-12374] #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59d1986
to
78b8f4c
Compare
78b8f4c
to
fb46688
Compare
Allure Report
processReports: ✅ test report for 2d041c8b
|
73dd30b
to
34db06e
Compare
d3fd91f
to
156cd64
Compare
b5f462e
to
b8f0de1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few comments with improvements. Let's discuss them and I can approve :)
588e17a
to
7d68125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @pczeglik-iohk ! 😄 🍻
89cd932
to
950ae43
Compare
edae8f0
to
79e706d
Compare
apps/browser-extension-wallet/transform-manifest-file-plugin.js
Outdated
Show resolved
Hide resolved
79e706d
to
0851473
Compare
Mozilla store does not allow it
Because of the dynamic nature of code chunks in Webpack and the way Firefox handles background scripts, we need to add a new custom plugin to the Webpack configuration. This plugin will transform manifest file and ensure that the background scripts are properly loaded in Firefox.
0851473
to
bdda05d
Compare
68613d5
to
2d041c8
Compare
|
Checklist
Proposed solution
In order to submit Lace extension to Mozilla's Web Store we need to meet requirement of source files not exceeding 4MB each. In this PR I'm updating webpack configs to split code into chunks smaller then 4MB and move nami icons to source code as
react-icons
library does not support tree-shaking, what creates a file bigger then 6 MB.Since this code is merged we will observe a new WARNING message in terminal output:
This is described in this file: apps/browser-extension-wallet/src/shims/inquire.js as
Additionally, in this PR I changed a bit the structure of the dist folder. Currently it looks like this: