fix: enhance test_checkers to cover new situations (#4942)

* fix: enhance test_checkers to cover new situations #4940

* fix: enhance test_checkers to cover new situations

Author: 22f1001635

cve_bin_tool/checkers/sqlite.py

@@ -97,6 +97,6 @@ def get_versions(self, lines, filename):
             # https://www.sqlite.org/c3ref/c_source_id.html
             if mapping[1][:-4] in lines:
                 # overwrite version with the version found by sha mapping
-                version_info.versions.append(mapping[0])
+                version_info.versions.add(mapping[0])
 
         return version_info

cve_bin_tool/util.py

@@ -215,22 +215,22 @@ class VersionMatchInfo:
     attributes:
         matched_filename: bool
         matched_contains: bool
-        versions: list[str]
+        versions: set[str]
     """
 
     matched_filename: bool
     matched_contains: bool
-    versions: list[str]
+    versions: set[str]
 
     def __init__(
         self,
         matched_filename: bool = False,
         matched_contains: bool = False,
-        versions: list[str] = [],
+        versions: set[str] | None = None,
     ):
         self.matched_filename = matched_filename
         self.matched_contains = matched_contains
-        self.versions = versions or []
+        self.versions = versions if versions is not None else set()
 
 
 class VersionInfo(NamedTuple):
@@ -280,24 +280,22 @@ def __missing__(self, key: str) -> list[CVE] | set[str]:
 
 def regex_find(
     lines: str, version_patterns: list[Pattern[str]], ignore: list[Pattern[str]]
-) -> list[str]:
+) -> set[str]:
     """Search a set of lines to find all matches for the given regex"""
-    versions = list()
+    versions = set()
 
     for pattern in version_patterns:
         version_matches = pattern.finditer(lines)
         for match in version_matches:
             # before collecting a potential version number, ensure the version string isn't on the ignore list
-            if not check_ignored(match.string, ignore):
+            matched_text = match.group(0)
+            if not check_ignored(matched_text, ignore):
                 version = match.group(1).strip()
                 version = version.replace("_", ".").replace("-", ".")
-                versions.append(version)
+                versions.add(version)
 
-    # if we searched and found no matches, just return a one-element list containing "UNKNOWN"
-    if not versions:
-        versions.append("UNKNOWN")
-
-    return versions
+    # if we searched and found no matches, just return a one-element set containing "UNKNOWN"
+    return versions if versions else {"UNKNOWN"}
 
 
 def check_ignored(possible_version_string: str, ignore: list[Pattern[str]]) -> bool:

test/test_checkers.py

@@ -145,12 +145,33 @@ class MyFakeChecker(Checker):
         VENDOR_PRODUCT = [("my", "checker")]
         IGNORE_PATTERNS = [r"mychecker-5.6"]
 
-    string = "Some other lines. \n Ignore this version pattern mychecker-5.6. \n Consider this version pattern mychecker-5.8. \n Some more lines."
-    lines = string.split("\n")
-    checker = MyFakeChecker()
-
-    result1 = checker.get_versions(lines[1], "")
-    assert result1.versions[0] == "UNKNOWN"
-
-    result2 = checker.get_versions(lines[2], "")
-    assert result2.versions[0] == "5.8"
+    class TestVersionParsing:
+        """Unit tests for MyFakeChecker class, validating version parsing and detection logic."""
+
+        @pytest.mark.parametrize(
+            "description, input_text, expected_versions",
+            [
+                (
+                    "Multiple valid versions",
+                    "mychecker-5.8\nmychecker-6.0",
+                    {"5.8", "6.0"},
+                ),
+                ("All versions ignored", "mychecker-5.6\nmychecker-5.6", {"UNKNOWN"}),
+                (
+                    "Mixed valid and ignored versions",
+                    "mychecker-5.8\nmychecker-5.6\nmychecker-6.0",
+                    {"5.8", "6.0"},
+                ),
+                ("No version pattern", "random text", set()),
+                (
+                    "Duplicate versions",
+                    "mychecker-5.8\nmychecker-5.8\nmychecker-6.0",
+                    {"5.8", "6.0"},
+                ),
+            ],
+        )
+        def test_checker_version(self, description, input_text, expected_versions):
+            """Test get_versions logic using MyFakeChecker class, ensuring multiple versions are processed correctly."""
+            checker = TestCheckerVersionParser.MyFakeChecker()
+            result = checker.get_versions(input_text, "")
+            assert result.versions == expected_versions, f"{description} failed"