-
Notifications
You must be signed in to change notification settings - Fork 531
test: Enhance test_checkers.py
to cover new situations
#4940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi. I would like to work on this issue. |
Hey @devesh-2002 , I've already completed some of the work on this. Would it be possible for you to take up another issue instead? Let me know what you think! |
@22f1001635 Quick heads up: issues marked as "Good first issue" are meant for folk who haven't had any merged PRs. You're too experienced to be working on them now, and there's a lot of GSoC folk who would really like to work on the easier stuff so please leave them for other people. Since @stvml has already been working on code review with you I'm going to let this one be, but next time please go ahead and work on one of the other 130+ issues available that haven't been specially tagged for beginners. If you're looking for a challenge, I'd really like someone to work on #4417 -- it's a lot of reading because of the debugging we did but my current thinking is that it's a bug where we can't handle "/" in a productname in the way the submitter was using the scanner. Given your experience writing tests, maybe you could start with some tests for special characters in productnames and see if you can figure out where it's going wrong? |
* fix: enhance test_checkers to cover new situations #4940 * fix: enhance test_checkers to cover new situations
There is currently a
MyFakeChecker
class intest/test_checkers.py
which tests two things:These test cases both work by running the test checker against a single string, then checking the first element of the returned list against the expected return value.
After #4911, checkers can now support finding multiple versions of a single product during a run, and we don't have tests confirming this works OK. I think we need at least these new test cases:
"UNKNOWN"
as its only element?The text was updated successfully, but these errors were encountered: