Skip to content

refactor: decode_cpe23 #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

refactor: decode_cpe23 #4268

merged 1 commit into from
Jul 29, 2024

Conversation

inosmeet
Copy link
Contributor

anthonyharrison
anthonyharrison reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@anthonyharrison anthonyharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Shouldn't we also add the decode_cpe22 and decode_purl routines int the util class as well?

@inosmeet
Copy link
Contributor Author

Makes sense. But there are two decode_purl functions within our project. One's already in util, which returns ProductInfo; the other in sboms section, which only decodes version from purl and is only used within it's origin. So maybe we can leave it be.

@mastersans
Copy link
Member

@inosmeet don't worry about the purl one i had plan to refactor them into one.

terriko
terriko approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's get this merged now and clean up the "duplicate" function later then.

@terriko terriko merged commit c7d1c45 into intel:main Jul 29, 2024
22 checks passed
@inosmeet inosmeet deleted the refactor branch July 30, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyharrison anthonyharrison anthonyharrison left review comments

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: decode_cpe23 de-duplication
4 participants
@inosmeet @mastersans @terriko @anthonyharrison