-
Notifications
You must be signed in to change notification settings - Fork 531
Added markdown linting to pre-commit hooks #4975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to remove all the other linters, which isn't going to work for us.
514aa5b
to
202b400
Compare
I have changed the commit as you said. Let me know if it looks good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close! One more minor fix needed, noted below.
As you said i added back the comment part in the file. |
6c287e3
to
07d6fbc
Compare
I’ve resolved the issue related to the failing test. The "Tests that may fail due to network or HTML" error has been addressed. Kindly check the updated status and let me know if anything else needs attention. |
2ae80c3
to
7eff409
Compare
a0535c1
to
e563a3d
Compare
d152191
to
b28f9b1
Compare
@terriko I am just not able to understand whats the issue with the workflows each time they are showing diif errors.Could you guide me in how to resolve this. |
5ed199f
to
47bb3f3
Compare
The Markdown linter has been acting inconsistently, and after discussing it, we agreed it’s better to hold off on merging until it’s more stable. For now, I’m closing this out so I can focus on other contributions without being blocked. |
This PR adds Markdown linting to the pre-commit hooks to ensure all .md files follow proper formatting standards. This helps maintain consistency and improves readability across the repository.
Updated .pre-commit-config.yaml to include markdownlint.
Removed unnecessary lines and reformatted the configuration file.
Installed and tested the pre-commit hook to ensure it runs correctly.
pre-commit install
pre-commit run markdownlint --all-files
Markdown files should follow the correct formatting.
pre-commit run --all-files should pass without errors.