Nginx Signing Key Update #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 29, 2024 17:24
…ure releases and break functionality (like with 3.12.4)
| fi | ||
| #set -- $i | ||
| set -- ${services[@]} | ||
| echo $1 $2 |
There was a problem hiding this comment.
looks like debug print that already printed below
| else | ||
| echo -e "[${RED}ERROR${NC}] container $2 unreachable from $1" | ||
| fi | ||
| #set -- $i |
There was a problem hiding this comment.
please remove the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The signing key that comes with the repo is causing signing errors. Either need to add instructions to the README to update signing key to the most relevant one or use the one included in this pull request. (From https://github.com/user-attachments/assets/a56d320a-cc97-4967-b59f-9a07cb0eec00)
Motivation and Context
Current pull from a repo blocks the docker compose build because the signing key throws a signing error
How Has This Been Tested?
Tested this setting up Gprofiler Performance Studio on c7i.4xl in AWS on U22.04
Screenshots
Checklist:
I have not added any instructions to the README, but that is an alternate solution
No new logic added