This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Ignore backend warning in discard event test #1050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CUDA backend may return a warning in memory prefetch with certain options. Since that does not affect the discard event test we should not fail when that happens. These changes allow the warning in the expected output. Signed-off-by: Larsen, Steffen <[email protected]>
| @@ -12,6 +12,10 @@ | |||
| // The test checks that the last parameter is not `nullptr` for all PI calls | |||
| // that should discard events. | |||
| // {{0|0000000000000000}} is required for various output on Linux and Windows. | |||
| // NOTE: piextUSMEnqueuePrefetch in the CUDA backend may return a warning | |||
| // result on Windows with error-code -996 | |||
| // (PI_ERROR_PLUGIN_SPECIFIC_ERROR). Since it is a warning it is safe to | |||
There was a problem hiding this comment.
Technically, the PI_ERROR_PLUGIN_SPECIFIC_ERROR can mean both error and warning, it is determined by a subsequent call to piPluginGetLastError. But I think it is OK for this test not to bother about it.
smaslov-intel
approved these changes
Jun 9, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
The CUDA backend may return a warning in memory prefetch with certain options. Since that does not affect the discard event test we should not fail when that happens. These changes allow the warning in the expected output. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…suite#1050) The CUDA backend may return a warning in memory prefetch with certain options. Since that does not affect the discard event test we should not fail when that happens. These changes allow the warning in the expected output. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CUDA backend may return a warning in memory prefetch with certain options. Since that does not affect the discard event test we should not fail when that happens. These changes allow the warning in the expected output.