Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Temporarily disabled unnormalized-clamp-linear-float.cpp #205

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

DenisBakhvalov
Copy link

Related issue: intel/llvm#8814

@cperkinsintel
Copy link

@DenisBakhvalov - this test is already marked XFAIL for LevelZero and Windows. Why is it necessary to further disable it? If we don't want the test run at all, we can switch XFAIL: to UNSUPPORTED:

@DenisBakhvalov
Copy link
Author

@cperkinsintel, based on what I saw, it sporadically passes on Windows + LevelZero, even though it is supposed to fail.

@cperkinsintel
Copy link

cperkinsintel commented Mar 30, 2021

@DenisBakhvalov , well let's just switch XFAIL: to UNSUPPORTED: if "sometimes passing" is a problem. Then the test won't be run at all.
Adding an outside requirement just makes it more complicated, especially since we want to maintain this test for other devices and platforms to catch any regressions. There are outstanding tickets for this problem. Once the L0 team get their fixes in, it'd be nice to be able to reactive this test easily.

bader
bader previously approved these changes Mar 30, 2021
@DenisBakhvalov
Copy link
Author

@DenisBakhvalov , well let's just switch XFAIL: to UNSUPPORTED: if "sometimes passing" is a problem. Then the test won't be run at all.
Adding an outside requirement just makes it more complicated, especially since we want to maintain this test for other devices and platforms to catch any regressions. There are outstanding tickets for this problem. Once the L0 team get their fixes in, it'd be nice to be able to reactive this test easily.

OK.

Copy link

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dm-vodopyanov
Copy link

@DenisBakhvalov
Copy link
Author

Just ran checks in #202 one more time, and now this test fails with OpenCL on Linux:
http://134.191.240.166:8010/blue/organizations/jenkins/LLVM-Test-Suite-CI%2FLLVM-Test-Suite-Lin/detail/LLVM-Test-Suite-Lin/455/pipeline#step-177-log-475

I think it's a different one. The failing test in your CI is Sampler/normalized-none-linear-float.cpp. Nevertheless, the issue seems a little annoying.

@cperkinsintel
Copy link

@dm-vodopyanov - I'll take care of it. We had to adjust the nonnormalized test last week. I'll update this one too. The OCL:CPU has an error where it gets flaky results on certain edge cases. There's an outstanding ticket on it, but I'll adjust the test in the interim.

@dm-vodopyanov
Copy link

Thanks a lot Chris! Denis, yes, sorry, this is completely another test, I didn't match the whole names.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants