Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Update tests with -fno-sycl-id-queries-fit-in-int option #220

Merged
merged 3 commits into from
Apr 8, 2021
Merged

[SYCL] Update tests with -fno-sycl-id-queries-fit-in-int option #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
258eec3
[SYCL] Update tests with -fno-sycl-id-queries-fit-in-int option
smanna12 Apr 5, 2021
0ec874c
Revert "[SYCL] Update tests with -fno-sycl-id-queries-fit-in-int option"
smanna12 Apr 5, 2021
99281c5
[SYCL] Update tests with -fno-sycl-id-queries-fit-in-int option
smanna12 Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SYCL/SubGroup/sub_group_as.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple -fno-sycl-id-queries-fit-in-int %s -o %t.out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, why those changes are needed at all?

Copy link
Author

@smanna12 smanna12 Apr 6, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexeySachkov for reviewing the patch.

intel/llvm#3427: Enables the option -fsycl-id-queries-fit-in-int to true by default. sub_group_as.cpp passes when the option is false on default mode but fails with default ON. So I added -fno-sycl-id-queries-fit-in-int to disable the option and match with the old behavior.

sycl-id-queries-fit-in-int makes a big impact on performance for DPC++ in many cases. The test failures currently block intel/llvm#3427. Is there any workaround i can use here? Thanks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like root cause for failing test is the same with post-commit failures after merging intel/llvm#3427

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vladimirlaz, PR: intel/llvm#3427: which has not been merged yet. I am waiting for this PR to be merged first before merging PR: intel/llvm#3427

// Sub-groups are not suported on Host
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
Expand Down
2 changes: 1 addition & 1 deletion SYCL/SubGroup/sub_group_as_vec.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple -fno-sycl-id-queries-fit-in-int %s -o %t.out
// Sub-groups are not suported on Host
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
Expand Down