This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Adopt test for CUDA backend #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value passed into memadvise is backend-specific. For OpenCL and Level Zero this test assumes 0 is a valid value. For CUDA this is not the case. The valid values for CUDA are 1 through 6.
|
SYCL :: Regression/implicit_offset_debug_info.cpp is known failure not related to the change. |
|
Submitted to avoid false alarms in CI |
|
It might have been a good idea to add a comment to explain why it was necessary to change the value depending on the backend. As someone reading this test who is unfamilair with the implementation detail, this change would be very confusing. |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
The value passed into memadvise is backend-specific. For OpenCL and Level Zero this test assumes 0 is a valid value. For CUDA this is not the case. The valid values for CUDA are 1 through 6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value passed into memadvise is backend-specific. For OpenCL and Level Zero
this test assumes 0 is a valid value. For CUDA this is not the case. The valid
values for CUDA are 1 through 6.