This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Update parallel_for_range.cpp test #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are due to the PR: intel/llvm#3427 Signed-off-by: Soumi Manna <[email protected]>
This reverts commit 258eec3.
Signed-off-by: Soumi Manna <[email protected]>
|
cuda failures are not connected to the change and can be ignored |
vladimirlaz
approved these changes
Jul 12, 2021
|
The patch should be merged before intel/llvm#4084. |
Thanks @vladimirlaz for the review. |
smaslov-intel
pushed a commit
to smaslov-intel/llvm-test-suite
that referenced
this pull request
Aug 12, 2021
The changes are due to the PR: intel/llvm#3427 Signed-off-by: Soumi Manna <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
The changes are due to the PR: intel#3427 Signed-off-by: Soumi Manna <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SYCL 1.2.1 spec, the attributes get propagated from device functions to a kernel.
The SYCL 2020 requirement mandating the avoidance of the propagation of all kernel attributes to the caller when used on a function.
The patch fixes failures caused by PR: intel/llvm#4084
where the attribute: reqd_work_group_size does not get propagated to the kernel/caller from device functions in SYCL 2020
as the default version in SYCL mode is 2020.
We are moving to SYCL 2020, so the test has been updated to reflect the SYCL 2020-compatible behavior.