This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add a test for group sorting algorithm #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
|
Inviting @romanovvlad for review. Feel free to invite more people if needed |
v-klochkov
reviewed
Sep 2, 2021
Pennycook
reviewed
Sep 2, 2021
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
Signed-off-by: Fedorov, Andrey <[email protected]>
|
Hi, all. Feel free to approve and merge if you don't have any more comments to the patch |
Currently the test fails in pre-commit - github UI doesn't allow to merge the patch. The implementation of the API this test validates should be merged first. |
Signed-off-by: Fedorov, Andrey <[email protected]>
romanovvlad
pushed a commit
to intel/llvm
that referenced
this pull request
Sep 15, 2021
…4439) This PR introduce the implementation for the Group Sort extension. The PR includes: Feature macro joint_sort and sort_over_group functions default_sorter group_with_scratchpad Algorithms are quite general. It should work with custom data types, custom comparators, custom sorters. The PR doesn't include: radix_sorter optimized specialization for arithmetic types Tests are here: intel/llvm-test-suite#438 Signed-off-by: Fedorov, Andrey [email protected]
|
@romanovvlad, implementation was merged to the |
|
@Pennycook, do you have any other comments/questions related to the PR? |
Pennycook
approved these changes
Sep 17, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
) Signed-off-by: Fedorov, Andrey <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of sorting algorithm is here: intel/llvm#4439
Cases that were added:
Data types:
Functors:
Sorters:
Sorting function:
Interfaces
Data size:
Generic group:
Cases that were not added:
Signed-off-by: Fedorov, Andrey [email protected]