[SYCL][ESIMD] Add test for esimd default constructor #565

vasilytric · 2021-11-11T09:52:57Z

This PR provides test for simd default constructor.
The test verifies that simd's elements value is equal to default value of element type
Also this PR provides common files:

function for printing verbose messaged into console
pre-defined sets of types for testing
function, that let iterating over pre-defined set of datatypes

yuriykoch · 2021-11-11T14:14:01Z

Please ensure you follow the LLVM Developer Policy as required by CONTRIBUTING.md.
More specifically, aren't the "add common code" and the "add test" commit messages too broad?

Also do we really need a separate "apply clang-format" commit? I mean, it looks like you were preparing the clean commit history before publishing your code anyway..

vasilytric · 2021-11-11T15:15:46Z

Please ensure you follow the LLVM Developer Policy as required by CONTRIBUTING.md.
More specifically, aren't the "add common code" and the "add test" commit messages too broad?

Commits messages was changed after force pushing

Also do we really need a separate "apply clang-format" commit? I mean, it looks like you were preparing the clean commit history before publishing your code anyway..

This commit was created after CI running and clang-format issues was found, but now this commit was deleted due to force pushing

yuriykoch

Thanks, looks great in general

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

SYCL/ESIMD/api/functional/logger.hpp

SYCL/ESIMD/api/functional/type_coverage.hpp

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

yuriykoch · 2021-11-18T12:41:11Z

This commit was created after CI running and clang-format issues was found

My bad. I've missed it, sorry for that

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

…ncapsulation levels

Add some struct that calls simd constructor, this let easily add new or delete existing test case

…unction

SYCL/ESIMD/api/functional/logger.hpp

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

SYCL/ESIMD/api/functional/type_coverage.hpp

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

SYCL/ESIMD/api/functional/logger.hpp

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

Base includes moved into common.hpp, removed "type_coverage" namespace and deleted "Logger struct", them methods now just a functions

- Now return named_type_pack without constructing some variable - change names fields of tested_types enum

vasilytric · 2021-11-22T15:29:55Z

@kbobrovs @v-klochkov could you review this test for esimd default constructor?

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

SYCL/ESIMD/api/functional/type_coverage.hpp

Add "#pragma once" and some includes into logger.hpp and type_coverage.hpp

yuriykoch · 2021-11-23T11:04:42Z

I would still strongly recommend to use api/functional/common.hpp instead of api/functional/ctors/common.hpp
as discussed earlier.
I can see no reason why we don't need such header for other functional tests and why we should move it later.

vasilytric · 2021-11-23T11:23:53Z

I would still strongly recommend to use api/functional/common.hpp instead of api/functional/ctors/common.hpp
as discussed earlier.
I can see no reason why we don't need such header for other functional tests and why we should move it later.

OK, I moved this file into SYCL/ESIMD/api/functional in this commit: 18c93a1

Fix text of the file description, update includes: fix path in includes due to some path have extra "../" and it is not correspond to current path, on Windows it was OK, but on Linux it could be compilation error

v-klochkov · 2021-12-02T00:59:11Z

Please fix the test, see the CI fail at the newly added test.

SYCL/ESIMD/api/functional/type_coverage.hpp

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

- Were reworked comments that can rot - Were changed some other comments

simd can't be constructed with sycl::half data type, i've done it for successfully running GitHub CI

List of required platforms should be separated by commas, it is required by the document "LLVM Testing Infrastructure Guide"

vasilytric · 2021-12-03T15:34:11Z

Please fix the test, see the CI fail at the newly added test.

The CI on Linux and Windows are passed, CI on cuda failed (expected to fail due to failures in previous runnings) due to another tests failures but test for simd constructor should be skipped on cuda
For issue with sycl::half was created bug on intel/llvm: intel/llvm/issues/5077

Also at the beginning of the tests was added comment about situation with sycl::half, it can be found here

@v-klochkov do you have any other comments to this PR? can we merge it?

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp

We requiring gpu and level_zero platforms due to the tests on simd constructors doesn't supported OPenCL platform yet

vasilytric · 2021-12-06T19:19:38Z

@v-klochkov CI on windows failed due to built-ins/vector_relational.cpp test, the test simd_ctor_default.cpp is not failed, so this failure is not related to reviewed test

vasilytric · 2021-12-07T05:33:00Z

@v-klochkov can we merge this PR?

…-suite#565)

yuriykoch suggested changes Nov 18, 2021

View reviewed changes

yuriykoch reviewed Nov 18, 2021

View reviewed changes

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp Outdated Show resolved Hide resolved

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp Outdated Show resolved Hide resolved

vasilytric added 7 commits November 19, 2021 14:47

[SYCL][ESIMD] Add common code for constructors tests

3ebc7a0

[SYCL][ESIMD] Add test for default constructor

475b410

[SYCL][ESIMD] Small improvements: add namespaces that correspond to e…

19fb012

…ncapsulation levels

[SYCL][ESIMD] Refactoring of "test" function

35fd849

Add some struct that calls simd constructor, this let easily add new or delete existing test case

[SYCL][ESIMD] Return passed status from all functions

ebaa8fc

[SYCL][ESIMD] Add function for obtain chosen types in named_type_pack

4970bd2

[SYCL][ESIMD] Use string representation of current data type in log f…

23971e1

…unction

yuriykoch reviewed Nov 22, 2021

View reviewed changes

vasilytric added 6 commits November 22, 2021 17:42

[SYCL][ESIMD] Small refactoring test for simd default constructor

3787c4f

Base includes moved into common.hpp, removed "type_coverage" namespace and deleted "Logger struct", them methods now just a functions

[SYCL][ESIMD] Small changes in type_coverage.hpp

334063f

- Now return named_type_pack without constructing some variable - change names fields of tested_types enum

[SYCL][ESIMD] Use string.empty() instead of strings comparison

98d9919

[SYCL][ESIMD] Remove SYCL_ESIMD_KERNEL for functions used in kernel

c201b25

[SYCL][ESIMD] Remove "using namespace sycl::ext::intel::experimental;"

a1b8cd7

[SYCL][ESIMD] Apply clang-format

0ddd7ef

kbobrovs requested a review from v-klochkov November 23, 2021 05:14

yuriykoch reviewed Nov 23, 2021

View reviewed changes

vasilytric added 3 commits November 23, 2021 13:14

[SYCL][ESIMD] Move includes from *.cpp file into common.hpp

9890c4c

[SYCL][ESIMD] Update logger.hpp and type_coverage.hpp

ce387ba

Add "#pragma once" and some includes into logger.hpp and type_coverage.hpp

[SYCL][ESIMD] Apply clang-format for type_coverage.hpp

e05e89e

[SYCL][ESIMD] Move common.hpp into SYCL/ESIMD/api/functional

18c93a1

[SYCL][ESIMD] Update common.hpp

79e8862

Fix text of the file description, update includes: fix path in includes due to some path have extra "../" and it is not correspond to current path, on Windows it was OK, but on Linux it could be compilation error

vasilytric mentioned this pull request Nov 26, 2021

[SYCL][ESIMD] Add test for esimd copy constructor #578

Merged

v-klochkov reviewed Dec 2, 2021

View reviewed changes

SYCL/ESIMD/api/functional/type_coverage.hpp Outdated Show resolved Hide resolved

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp Outdated Show resolved Hide resolved

vasilytric added 5 commits December 2, 2021 14:49

[SYCL][ESIMD] Update comments

d56ee8f

- Were reworked comments that can rot - Were changed some other comments

[SYCL][ESIMD] Remove unnecessary kernel

44ec7a5

[SYCL][ESIMD] Add TEST_HALF macros for sycl::half variables

f88bb8d

simd can't be constructed with sycl::half data type, i've done it for successfully running GitHub CI

[SYCL][ESIMD] Use comma separator in list required platforms for testing

b9ac33f

List of required platforms should be separated by commas, it is required by the document "LLVM Testing Infrastructure Guide"

[SYCL][ESIMD] Add comment that simd constructor not support sycl::half

d1ab19e

v-klochkov reviewed Dec 3, 2021

View reviewed changes

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp Outdated Show resolved Hide resolved

SYCL/ESIMD/api/functional/ctors/ctor_default.cpp Show resolved Hide resolved

vasilytric added 3 commits December 6, 2021 10:59

[SYCL][ESIMD] Use comma-separator on unsupported platforms

18efcb8

[SYCL][ESIMD] Update comment about issue with simd constructor

11cca0a

SYCL][ESIMD] Add "XREQUIRES" field and description of unsupp platform

84aa45d

We requiring gpu and level_zero platforms due to the tests on simd constructors doesn't supported OPenCL platform yet

v-klochkov approved these changes Dec 6, 2021

View reviewed changes

vladimirlaz merged commit 17894ea into intel:intel Dec 8, 2021

aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023

[SYCL][ESIMD] Add test for esimd default constructor (intel/llvm-test…

bb7d751

…-suite#565)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL][ESIMD] Add test for esimd default constructor #565

[SYCL][ESIMD] Add test for esimd default constructor #565

vasilytric commented Nov 11, 2021 •

edited

Loading

yuriykoch commented Nov 11, 2021

vasilytric commented Nov 11, 2021

yuriykoch left a comment

yuriykoch commented Nov 18, 2021

vasilytric commented Nov 22, 2021

yuriykoch commented Nov 23, 2021

vasilytric commented Nov 23, 2021

v-klochkov commented Dec 2, 2021

vasilytric commented Dec 3, 2021

vasilytric commented Dec 6, 2021

vasilytric commented Dec 7, 2021

[SYCL][ESIMD] Add test for esimd default constructor #565

[SYCL][ESIMD] Add test for esimd default constructor #565

Conversation

vasilytric commented Nov 11, 2021 • edited Loading

yuriykoch commented Nov 11, 2021

vasilytric commented Nov 11, 2021

yuriykoch left a comment

Choose a reason for hiding this comment

yuriykoch commented Nov 18, 2021

vasilytric commented Nov 22, 2021

yuriykoch commented Nov 23, 2021

vasilytric commented Nov 23, 2021

v-klochkov commented Dec 2, 2021

vasilytric commented Dec 3, 2021

vasilytric commented Dec 6, 2021

vasilytric commented Dec 7, 2021

vasilytric commented Nov 11, 2021 •

edited

Loading