Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] [FPGA] Update latency control E2E tests #982

Merged

Conversation

shuoniu-intel
Copy link

Update latency control E2E tests to use property list in the API.

The corresponding SYCL PR: intel/llvm#5993

@shuoniu-intel shuoniu-intel force-pushed the latency-control-properties-e2e branch from 50d009e to 1c6dbd7 Compare April 8, 2022 20:05
@shuoniu-intel shuoniu-intel marked this pull request as ready for review April 9, 2022 14:22
@shuoniu-intel shuoniu-intel requested a review from a team as a code owner April 9, 2022 14:22
steffenlarsen
steffenlarsen previously approved these changes Apr 13, 2022
@shuoniu-intel
Copy link
Author

/verify with intel/llvm#5993

steffenlarsen pushed a commit to intel/llvm that referenced this pull request Apr 28, 2022
…erty list (#5993)

As planned before, this patch deprecates the template argument approach in the experimental latency control API, and use property list instead. 
I'm still updating the experimental API rather than the formal API because the frontend support (clang and SPIR-V) for latency control is not ready yet, so I'd like to wait for them before fully moving on to deprecate the experimental API.

---
This patch contains three parts:
- Update the extension documents for pipes and LSUs, change the experimental latency control to use property list in the API.
  - sycl/doc/extensions/supported/sycl_ext_intel_dataflow_pipes.asciidoc
  - sycl/doc/extensions/supported/sycl_ext_intel_fpga_lsu.md
- Create properties for latency control.
  - sycl/include/sycl/ext/oneapi/latency_control/properties.hpp
  - sycl/include/sycl/ext/oneapi/properties/property.hpp
  - sycl/test/extensions/properties/properties_latency_control.cpp
- Update headers for the experimental latency control, change the API to use property list.
  - sycl/include/sycl/ext/intel/experimental/fpga_utils.hpp
  - sycl/include/sycl/ext/intel/experimental/fpga_lsu.hpp
  - sycl/include/sycl/ext/intel/experimental/pipes.hpp
 
Test: intel/llvm-test-suite#982
@steffenlarsen steffenlarsen merged commit 2b77270 into intel:intel Apr 28, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
Update latency control E2E tests to use property list in the API.

The corresponding SYCL PR: intel/llvm#5993
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…#982)

Update latency control E2E tests to use property list in the API.

The corresponding SYCL PR: intel#5993
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants