Skip to content

Commit 2e1c36f

Browse files
authored
[SYCL] Remove experimental/builtins.hpp from sycl.hpp due to C++17 (#6386)
C++17 usage of if constexpr etc was added to experimental/builtins.hpp as requested in #5964, but I did not remove this header from sycl.hpp since there were no failing tests and I didn't notice it was included in sycl.hpp. Apparently sycl.hpp should not include any usage of C++17. This may be related to some of the failing tests that appear only on the CI: intel/llvm-test-suite#975 (comment). Necessary changes to the tests are added here : intel/llvm-test-suite#1072 Signed-off-by: JackAKirk [email protected]
1 parent d291f77 commit 2e1c36f

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

sycl/include/CL/sycl.hpp

-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
#include <sycl/ext/oneapi/backend/level_zero.hpp>
6262
#endif
6363
#include <sycl/ext/oneapi/device_global/properties.hpp>
64-
#include <sycl/ext/oneapi/experimental/builtins.hpp>
6564
#include <sycl/ext/oneapi/experimental/cuda/barrier.hpp>
6665
#include <sycl/ext/oneapi/filter_selector.hpp>
6766
#include <sycl/ext/oneapi/group_algorithm.hpp>

sycl/test/basic_tests/built-ins.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
// Hits an assertion with AMD:
88
// XFAIL: hip_amd
99

10-
#include <CL/sycl.hpp>
10+
#include <sycl/ext/oneapi/experimental/builtins.hpp>
11+
#include <sycl/sycl.hpp>
1112

1213
#include <cassert>
1314

sycl/test/extensions/experimental-printf.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
// CHECK: Constant [[#TYPE]] [[#CONST:]]
1717
// CHECK: ExtInst [[#]] [[#]] [[#]] printf [[#]] [[#CONST]]
1818

19-
#include <CL/sycl.hpp>
19+
#include <sycl/ext/oneapi/experimental/builtins.hpp>
20+
#include <sycl/sycl.hpp>
2021

2122
#ifdef __SYCL_DEVICE_ONLY__
2223
#define __SYCL_CONSTANT_AS __attribute__((opencl_constant))

0 commit comments

Comments
 (0)