[SYCL] Remove experimental/builtins.hpp from sycl.hpp due to C++17 #6386
Conversation
Signed-off-by: JackAKirk <[email protected]>
|
/verify with intel/llvm-test-suite#1072 |
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
|
/verify with intel/llvm-test-suite#1072 |
|
@pvchupin, please, do not merge pull requests introducing regressions. Pre-commit for this PR fails. @JackAKirk, @pvchupin, I also think the PR must be reviewed before the merge. |
|
@bader, I decided to took the risk here (on both merge and no-review) because this PR was fixing another set of issues appearing in many pre-commits that were hard to reproduce. I tested locally in the limited environment where reproducer actually succeeded, and testing passed but I didn't test all possible configurations and some new fails were unexpected. Now we had a better sync on this let's proceed with solution in #6400. |
Reverts #6386 so that experimental/builtins.hpp is included in sycl.hpp. This avoids users being required to include this header when using printf or experimental math functions. Corresponding update here: intel/llvm-test-suite#1076.
C++17 usage of
if constexpretc was added to experimental/builtins.hpp as requested in #5964, but I did not remove this header from sycl.hpp since there were no failing tests and I didn't notice it was included in sycl.hpp. Apparently sycl.hpp should not include any usage of C++17. This may be related to some of the failing tests that appear only on the CI: intel/llvm-test-suite#975 (comment). Necessary changes to the tests are added here : intel/llvm-test-suite#1072Signed-off-by: JackAKirk [email protected]