[SYCL][ESIMD] Remove LowerESIMDVecArg pass and update opaque pointer tests (#10738)

After
0c51f60,
opaque pointers are enabled by default for device code.

This means that LowerESIMDVecArg is now never run because we do a
runtime check in sycl-post-link and only run it if opaque pointers are
off.

Remove the pass since it's now dead code, and remove related tests. The
tests check for changes unique to LowerESIMDVecArg and cannot be ported
to instead use the pass that is run when opaque pointers is enabled,
ESIMDOptimizeVecArgCallConvPass, and that pass has its own tests already
and it does something completely different anyway.

For the tests removed under sycl/test/esimd, all of those tests already
have opaque pointer versions in-tree with the _opaque suffix, so there
is no test coverage loss.

I also updated tests in sycl/test that have the _opaque suffix to not
have the suffix, removed the typed pointer versions, and removed the
opaque pointer flags.

---------

Signed-off-by: Sarnie, Nick <[email protected]>

Author: sarnex

llvm/include/llvm/InitializePasses.h

@@ -337,7 +337,6 @@ void initializeSYCLLowerInvokeSimdLegacyPassPass(PassRegistry &);
 void initializeSYCLMutatePrintfAddrspaceLegacyPassPass(PassRegistry &);
 void initializeSPIRITTAnnotationsLegacyPassPass(PassRegistry &);
 void initializeESIMDLowerLoadStorePass(PassRegistry &);
-void initializeESIMDLowerVecArgLegacyPassPass(PassRegistry &);
 void initializeESIMDVerifierPass(PassRegistry &);
 void initializeSYCLLowerWGLocalMemoryLegacyPass(PassRegistry &);
 void initializeTailCallElimPass(PassRegistry&);

llvm/include/llvm/SYCLLowerIR/ESIMD/LowerESIMD.h

@@ -52,20 +52,6 @@ class ESIMDLowerLoadStorePass : public PassInfoMixin<ESIMDLowerLoadStorePass> {
 FunctionPass *createESIMDLowerLoadStorePass();
 void initializeESIMDLowerLoadStorePass(PassRegistry &);
 
-// Pass converts simd* function parameters and globals to
-// llvm's first-class vector* type.
-class ESIMDLowerVecArgPass : public PassInfoMixin<ESIMDLowerVecArgPass> {
-public:
-  PreservedAnalyses run(Module &M, ModuleAnalysisManager &);
-
-private:
-  Function *rewriteFunc(Function &F);
-  Type *getSimdArgPtrTyOrNull(Value *arg);
-};
-
-ModulePass *createESIMDLowerVecArgPass();
-void initializeESIMDLowerVecArgLegacyPassPass(PassRegistry &);
-
 // - Converts simd* function parameters and return values passed by pointer to
 // pass-by-value
 //   (where possible)

llvm/lib/Passes/PassRegistry.def

@@ -129,7 +129,6 @@ MODULE_PASS("memprof-module", ModuleMemProfilerPass())
 MODULE_PASS("poison-checking", PoisonCheckingPass())
 MODULE_PASS("pseudo-probe-update", PseudoProbeUpdatePass())
 MODULE_PASS("LowerESIMD", SYCLLowerESIMDPass())
-MODULE_PASS("ESIMDLowerVecArg", ESIMDLowerVecArgPass())
 MODULE_PASS("esimd-opt-call-conv", ESIMDOptimizeVecArgCallConvPass())
 MODULE_PASS("esimd-verifier", ESIMDVerifierPass())
 MODULE_PASS("lower-invoke-simd", SYCLLowerInvokeSimdPass())

llvm/lib/SYCLLowerIR/CMakeLists.txt

@@ -54,7 +54,6 @@ add_llvm_component_library(LLVMSYCLLowerIR
   ESIMD/LowerESIMDKernelAttrs.cpp
   CompileTimePropertiesPass.cpp
   DeviceGlobals.cpp
-  ESIMD/LowerESIMDVecArg.cpp
   ESIMD/LowerESIMDVLoadVStore.cpp
   ESIMD/LowerESIMDSlmReservation.cpp
   HostPipes.cpp