[SYCL] Locks in the ProgramManager should be revisited #18165
Labels
Comments
ianayl
added
enhancement
martygrant
pushed a commit
that referenced
this issue
Apr 24, 2025
#18121) This PR guards accesses to `m_DeviceImage` and `m_VFSet2BinImage` caches/maps in the Program Manager using `m_KernelIDsMutex` in situations where multiple threads may be accessing the maps at the same time. I am opting to use `m_KernelIDsMutex` here as both maps are commonly accessed while holding said mutex: In fact, a lot of maps/caches in the program manager use `m_KernelIDsMutex` (This is not the most optimal solution, but that is out of the scope of this PR, see #18165) This PR addresses Coverity hits that needs to have fixes submitted before the code cutoff. --------- Co-authored-by: Steffen Larsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Locking in the ProgramManager should be revisited, as:
ProgramManager::m_EliminatedKernelArgMasksis not protected by a mutex #16836m_KernelIDsMutexthat do not seem related to the Kernel ID cache: Either way, introducing more mutexes may enable more threads to do more at the same time.m_ExportedSymbolImages,m_DeviceImages,m_VFSet2BinImage, please see program_manager.hppThe text was updated successfully, but these errors were encountered: