Skip to content

[SYCL] Default selector should filter devices based on available device images #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbrodman opened this issue Jun 29, 2020 · 3 comments
Closed

[SYCL] Default selector should filter devices based on available device images #2004

jbrodman opened this issue Jun 29, 2020 · 3 comments
Labels
bug Something isn't working Stale

Comments

@jbrodman
Copy link
Contributor

The default selector should not select a device for which no devices images exist.

Example: Don't pick a CUDA device if there are no PTX modules in the fat binary. Likewise don't pick a CL device if there are no SPIR-V modules or AOT binary images.
@jbrodman jbrodman added the bug Something isn't working label Jun 29, 2020
@bader
Copy link
Contributor

bader commented Jun 29, 2020

Related issues:

@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 18, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 30 days with no activity. Please, re-open if the issue still exists.

@npmiller npmiller mentioned this issue May 26, 2022
Merged
pvchupin pushed a commit that referenced this issue Jun 7, 2022
@npmiller
[SYCL] Don't select devices with no available images (#6203)
0e67db8 
This patch solves:

* [SYCL] Default selector should filter devices based on available device images #2004
* [SYCL][CUDA] Default selector behaviour #1665

In some cases the current selector may select a device for which we don't have an AOT or SPIR-V binary for, this patch ensures that such devices get skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bader @jbrodman