-
Notifications
You must be signed in to change notification settings - Fork 770
Enable back hier_par_wgscope_O0.cpp and generic-shuffle.cpp which are temporarily marked as Unsupported #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
-// XFAIL: accelerator || (system-windows && cpu) Why? It's supposed to be supported. AFAIK, @againull is working on resolving these failures. The same is applied to sub-groups on CPU. |
Changing OpenCL RTs exposed several flacky issues. We disabled these test to let us move forward with update and fix tets afterwords. |
Do you plan to fix "flacky issues"? Just disabling the test doesn't seem like the right approach to me. |
this is the reason to have this issue openned:) |
It seems to me that PR title and description say the opposite: "Mark hier_par_wgscope_O0.cpp and generic-shuffle.cpp as Unsupported". |
…#2228) This is done to provide smooth drivers transition to official extensions. Also updated tests for new extensions to use new tokens after KhronosGroup/SPIRV-Headers@cca08c6 Original commit: KhronosGroup/SPIRV-LLVM-Translator@32786ff
[L0] Refactor Copy Engine Usage checks for Performance
Uh oh!
There was an error while loading. Please reload this page.
Following is the change to mark.
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// RUN: %ACC_RUN_PLACEHOLDER %t.out
-// XFAIL: accelerator || (system-windows && cpu)
+// UNSUPPORTED: accelerator || (system-windows && cpu)
// This test checks correctness of hierarchical kernel execution when there is
// code and data in the work group scope, and when the test is compiled with
-// UNSUPPORTED: cuda
+// UNSUPPORTED: cuda || cpu
// CUDA compilation and runtime do not yet support sub-groups.
//
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
The text was updated successfully, but these errors were encountered: