Skip to content

Enable back hier_par_wgscope_O0.cpp and generic-shuffle.cpp which are temporarily marked as Unsupported #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yinyangsx opened this issue Jul 31, 2020 · 5 comments · Fixed by #2244
Assignees

Comments

@yinyangsx
Copy link

yinyangsx commented Jul 31, 2020

Following is the change to mark.

  1. sycl/test/hier_par/hier_par_wgscope_O0.cpp
    // RUN: %GPU_RUN_PLACEHOLDER %t.out
    // RUN: %ACC_RUN_PLACEHOLDER %t.out

-// XFAIL: accelerator || (system-windows && cpu)
+// UNSUPPORTED: accelerator || (system-windows && cpu)

// This test checks correctness of hierarchical kernel execution when there is
// code and data in the work group scope, and when the test is compiled with

  1. sycl/test/sub_group/generic-shuffle.cpp
    -// UNSUPPORTED: cuda
    +// UNSUPPORTED: cuda || cpu
    // CUDA compilation and runtime do not yet support sub-groups.
    //
    // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
@bader
Copy link
Contributor

bader commented Jul 31, 2020

-// XFAIL: accelerator || (system-windows && cpu)
+// UNSUPPORTED: accelerator || (system-windows && cpu)

Why? It's supposed to be supported. AFAIK, @againull is working on resolving these failures.

The same is applied to sub-groups on CPU.

@vladimirlaz
Copy link
Contributor

Changing OpenCL RTs exposed several flacky issues. We disabled these test to let us move forward with update and fix tets afterwords.

@bader
Copy link
Contributor

bader commented Jul 31, 2020

Do you plan to fix "flacky issues"? Just disabling the test doesn't seem like the right approach to me.

@vladimirlaz
Copy link
Contributor

this is the reason to have this issue openned:)

@bader
Copy link
Contributor

bader commented Jul 31, 2020

It seems to me that PR title and description say the opposite: "Mark hier_par_wgscope_O0.cpp and generic-shuffle.cpp as Unsupported".

@vladimirlaz vladimirlaz changed the title Mark hier_par_wgscope_O0.cpp and generic-shuffle.cpp as Unsupported Enable back hier_par_wgscope_O0.cpp and generic-shuffle.cpp which are temporarily marked as Unsupported Aug 3, 2020
jsji pushed a commit that referenced this issue Nov 30, 2023
…#2228)

This is done to provide smooth drivers transition to official
extensions.
Also updated tests for new extensions to use new tokens after
KhronosGroup/SPIRV-Headers@cca08c6

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@32786ff
Chenyang-L pushed a commit that referenced this issue Feb 18, 2025
[L0] Refactor Copy Engine Usage checks for Performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants