No diagnostic for checking reqd_work_group_size and reqd_work_group_size attributes when merging #5735
Comments
bader
pushed a commit
that referenced
this issue
Mar 22, 2022
This patch
1. refactors SYCL kernel function attribute reqd_work_group_size to better fit for community standards.
2. refactors the way we handled duplicate attributes logic with when present on a given declaration.
3. refactors the way we handled mutually exclusive attributes logic with when present on a given declaration with
reqd_work_group_size, max_work_group_size, max_global_work_dim, and num_simd_work_items attributes.
5. handles redeclarations or template instantiations properly.
6. stores ConstantExpr into the semantic attribute rather than calling getIntegerConstantExpr() for attribute dimension values.
7. fixes crash with optional arguments on ReqdWorkGroupAttr and adds missing diagnostics for merging cases when present
on a given declaration with reqd_work_group_size, max_work_group_size, max_global_work_dim, and num_simd_work_items
attributes.
8. updates clang-tidy build after reqd_work_group_size attribute changes.
9. adds tests.
This patch fixes
#5736, #5735, #5734, #5732, #5731, #3223, #3361, #3175, #3742, and #5733
Signed-off-by: Soumi Manna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
// FIXME: We do not have support yet for checking
// reqd_work_group_size and reqd_work_group_size
// attributes when merging, so the test compiles without
// any diagnostic when it shouldn't
[[sycl::reqd_work_group_size(32, 1, 1)]] void f(); // expected-note {{conflicting attribute is here}} now OK
[[sycl::reqd_work_group_size(1, 1, 32)]] void f(); // expected-error{{'reqd_work_group_size' attribute conflicts with 'reqd_work_group_size' attribute}} now OK
The text was updated successfully, but these errors were encountered: