Skip to content

[SYCL][PI] Design PI plugin lookup to be reusable in tools and tests #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjoernknafla opened this issue Oct 16, 2019 · 2 comments
Closed

[SYCL][PI] Design PI plugin lookup to be reusable in tools and tests #741

bjoernknafla opened this issue Oct 16, 2019 · 2 comments
Assignees
@alexbatashev

Comments

@bjoernknafla
Copy link
Contributor

With the move to PI plugins as dynamic libraries as documented here the PI unittests need to be changed.

Ideally PI plugin discovery should use the same mechanism as the one used by the SYCL runtime.

If it was possible to set up the PI plugin discovery mechanism as a (static?) library, then PI specific unittests and other tools on top of PI would be straightforward to implement.
@bjoernknafla bjoernknafla changed the title Design PI plugin lookup as a library itself [SYCL][PI] Design PI plugin lookup as a library itself Oct 16, 2019
@bjoernknafla bjoernknafla changed the title [SYCL][PI] Design PI plugin lookup as a library itself [SYCL][PI] Design PI plugin lookup to be reusable in tools and tests Oct 16, 2019
vladimirlaz pushed a commit to vladimirlaz/llvm that referenced this issue Sep 13, 2020
@fadeeval @vladimirlaz
Fix nullptr dereference (intel#741)
3addf30 
Replaced nullptr with an empty string
alexbatashev pushed a commit to alexbatashev/llvm that referenced this issue Sep 17, 2020
Merge remote-tracking branch 'upstream/sycl' into accessor_property_list
7a51468 
* upstream/sycl: (405 commits)
  [SYCL] Implement new env var SYCL_DEVICE_FILTER (intel#2239)
  [Driver][SYCL] Make /MD the default for -fsycl (intel#2478)
  [SYCL]: basic support of contexts with multiple devices in Level-Zero (intel#2440)
  [SYCL] Fix LIT regression after 9dd18ca (intel#2481)
  [SYCL][L0] Kernel Destroy in piKernelRelease (intel#2475)
  [SYCL] Emit an aliased function only if it is used (intel#2430)
  [Driver][SYCL] Add defaultlib directive for sycl lib (intel#2464)
  [Driver][SYCL] Improve situations where .exe is added for AOT tools (intel#2467)
  [SYCL][L0]: Check Queue refcnt prior to using members in event wait/release (intel#2471)
  [SYCL] Unroll several loops in __init method accessor class (intel#2449)
  [SYCL][Doc] Add link to use pinned memory spec (intel#2463)
  [SYCL] Link SYCL device libraries by default. (intel#2400)
  Revert "[SYCL] XFAIL test blcoking pulldown"
  Avoid usage of deprecated "VectorType::getNumElements" (intel#737)
  Fix nullptr dereference (intel#741)
  Do not translate arbitrary precision operations without corresponding extensions (intel#714)
  Add Constrained Floating-Point Intrinsics support
  [SYCL] Take into account auxiliary cmake options for Level Zero loader
  [InstCombine] improve fold of pointer differences
  [InstCombine] add ptr difference tests; NFC
  ...
@github-actions
Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 19, 2022
@alexbatashev alexbatashev self-assigned this Feb 19, 2022
@romanovvlad
Copy link
Contributor

The current plan is to get rid of real plugin discovery logic in unittests(see https://github.com/intel/llvm/pull/6684/files) and there are no tools(please correct me if I'm wrong) which would reuse this functionality. So, closing this, we can get back to this if we find more use cases. Please, feel free to reopen if there are any concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexbatashev alexbatashev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bjoernknafla @alexbatashev @romanovvlad