[SYCL][USM] Add templated forms of USM mallocs #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <[email protected]>
bader
reviewed
Feb 3, 2020
There was a problem hiding this comment.
LGTM in general, just a couple of minor issues.
It would great to add a test verifying new API.
Should we extend documentation?
|
bah forgot to include the new test in the PR. |
Signed-off-by: James Brodman <[email protected]>
bader
approved these changes
Feb 5, 2020
ldorau
added a commit
to ldorau/llvm
that referenced
this pull request
Feb 17, 2025
Update UMF to the latest commit:
commit 5a515c56c92be75944c8246535c408cee7711114
Author: Lukasz Dorau <[email protected]>
Date: Mon Feb 17 10:56:05 2025 +0100
Merge pull request intel#1086 from vinser52/svinogra_l0_linking
to fix the issue in LLVM (SYCL/CUDA):
intel#16944
[SYCL][CUDA] Nsys profiling broken after memory providers change
Fixes: intel#16944
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
added a commit
to ldorau/llvm
that referenced
this pull request
Feb 18, 2025
Update UMF to the latest commit:
commit 5a515c56c92be75944c8246535c408cee7711114
Author: Lukasz Dorau <[email protected]>
Date: Mon Feb 17 10:56:05 2025 +0100
Merge pull request intel#1086 from vinser52/svinogra_l0_linking
to fix the issue in LLVM (SYCL/CUDA):
intel#16944
[SYCL][CUDA] Nsys profiling broken after memory providers change
Fixes: intel#16944
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
added a commit
to ldorau/llvm
that referenced
this pull request
Feb 19, 2025
Update UMF to the commit: commit 5a515c56c92be75944c8246535c408cee7711114 Author: Lukasz Dorau <[email protected]> Date: Mon Feb 17 10:56:05 2025 +0100 Merge pull request intel#1086 from vinser52/svinogra_l0_linking to fix the issue in LLVM (SYCL/CUDA): intel#16944 [SYCL][CUDA] Nsys profiling broken after memory providers change Fixes: intel#16944 Signed-off-by: Lukasz Dorau <[email protected]>
steffenlarsen
pushed a commit
that referenced
this pull request
Feb 20, 2025
Update UMF to the commit:
```
commit 5a515c56c92be75944c8246535c408cee7711114
Author: Lukasz Dorau <[email protected]>
Date: Mon Feb 17 10:56:05 2025 +0100
Merge pull request #1086 from vinser52/svinogra_l0_linking
```
to fix the issue in LLVM (SYCL/CUDA):
#16944
[SYCL][CUDA] Nsys profiling broken after memory providers change
Moved from: oneapi-src/unified-runtime#2708
Fixes: #16944
Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ programmers prefer nice clean templates over void *.
Signed-off-by: James Brodman [email protected]