[SYCL] Add tests for atomic operations on malloc_shared-allocated memory

[pasaulais]

This duplicates existing SYCL atomic tests that use buffers with identical tests that use USM and memory allocated using sycl::malloc_shared. The motivation behind exercising atomics on malloc_shared-allocated memory is to catch issues such as ROCm/ROCm#848 where native atomic instructions may fail when crossing the PCIe bus.

[pasaulais]

This PR so far only contains changes to the 'add' atomic tests to get initial feedback. I will add other tests later so that review feedback won't potentially require all tests to be changed.

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[maarquitos14]

This PR so far only contains changes to the 'add' atomic tests to get initial feedback. I will add other tests later so that review feedback won't potentially require all tests to be changed.

The changes so far look good to me. Only one nit: comments are supposed to be written in proper English, i.e. with proper punctuation. I noticed that you simply copy-pasted the comments from existing tests into the new tests, but can you add the . at the end of the sentence for each of them? Just for the newly added ones.

[pasaulais]

This PR so far only contains changes to the 'add' atomic tests to get initial feedback. I will add other tests later so that review feedback won't potentially require all tests to be changed.

The changes so far look good to me. Only one nit: comments are supposed to be written in proper English, i.e. with proper punctuation. I noticed that you simply copy-pasted the comments from existing tests into the new tests, but can you add the . at the end of the sentence for each of them? Just for the newly added ones.

No problem. I've clang-formatted my changes and added . to the comments in the new code. I can do it for the existing code as well as I go. Is there any reason not to, like keeping the diff simple?

[maarquitos14]

No problem. I've clang-formatted my changes and added . to the comments in the new code. I can do it for the existing code as well as I go. Is there any reason not to, like keeping the diff simple?

Yes, that's exactly it, we want to keep the diff simple.

[pasaulais]

@maarquitos14 I have completed the tests for all atomic operations present in the test-e2e/AtomicRef folder, using the same approach as the 'add' test you've already reviewed. Could you take another look at it?

[pasaulais]

Thanks for your comments @maarquitos14, I think I've addressed all of them.

[pasaulais]

All atomic tests now seem to be failing on CI (AMD HIP only as far as I can see) with:

# | terminate called after throwing an instance of 'sycl::_V1::exception'
# |   what():  Device does not support shared USM allocations!

This seems to have been introduced by #12700. I'm not sure why this is not supported on AMD HIP, but either way the tests need to be modified to check for shared USM support.

[maarquitos14]

LGTM.