-
Notifications
You must be signed in to change notification settings - Fork 770
[UR] Add urProgramGetGlobalVariablePointer entrypoint #12496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UR] Add urProgramGetGlobalVariablePointer entrypoint #12496
Conversation
512ba15
to
2dd9099
Compare
ef3025e
to
e1d0b8c
Compare
e1d0b8c
to
fa51e98
Compare
fa51e98
to
5f197a8
Compare
5f197a8
to
208d396
Compare
@@ -56,14 +56,14 @@ endif() | |||
if(SYCL_PI_UR_USE_FETCH_CONTENT) | |||
include(FetchContent) | |||
|
|||
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") | |||
set(UNIFIED_RUNTIME_REPO "https://github.com/fabiomestre/unified-runtime.git") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be updated to point to the right commit / repo once the PR on the Unified Runtime repo is merged: oneapi-src/unified-runtime#1255
Gentle ping for reviews from @intel/dpcpp-nativecpu-pi-reviewers @intel/llvm-reviewers-cuda @sergey-semenov |
208d396
to
1ed9dc7
Compare
1ed9dc7
to
e370466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU lgtm, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA and HIP LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a version bump, then this looks good!
@intel/llvm-gatekeepers please merge |
Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
No description provided.