[SYCL][NATIVECPU] Separate lit tag for oneAPI Construction Kit #12864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -159,6 +159,9 @@ | |||
| if config.native_cpu_be == "ON": | |||
| config.available_features.add("native_cpu_be") | |||
|
|
|||
| if config.native_cpu_ock == "ON": | |||
| config.available_features.add("native_cpu_ock") | |||
There was a problem hiding this comment.
Is oneAPI Construction Kit really tied to the native cpu? Or maybe we should remove the "native_cpu" prefix here (and expand the ock abbreviation slightly)?
There was a problem hiding this comment.
Currently it gets fetched only when building the native cpu backend, this prefix is intended to be "native cpu with OCK"
There was a problem hiding this comment.
Ok, we can always change it later it other uses are added.
aelovikov-intel
approved these changes
Feb 29, 2024
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PietroGhg
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
approved these changes
Mar 1, 2024
|
Hi @intel/llvm-gatekeepers, this looks ready to be merged, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the oneAPI Construction Kit is an optional dependency for the Native CPU backend, so we need to differentiate test requirements based on whether or not it is available.