[SYCL][Bindless][Doc] Add support for cubemaps #12996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allocation and freeing of cubemapped images - Unsampled fetching and writing, and sampled reading - Device queries for cubemap support - Testing for both unsampled and sampled cubemap examples - Update the spec with cubemap support
Seanst98
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
isaacault
approved these changes
Mar 15, 2024
|
Make sure to keep an eye on if [SYCL][Bindless] Add image_mem_handle to image_mem_handle devices copies. gets merged first. In the case that it does, |
|
Friendly ping @intel/dpcpp-tools-reviewers, @intel/unified-runtime-reviewers, @intel/llvm-reviewers-runtime, @intel/llvm-reviewers-cuda, @maarquitos14, and @jchlanda for reviews/approvals |
JackAKirk
reviewed
Mar 18, 2024
DBDuncan
approved these changes
Mar 18, 2024
AlexeySachkov
approved these changes
Mar 18, 2024
maarquitos14
approved these changes
Apr 2, 2024
UR TAG has also been updated
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
przemektmalon
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aarongreig
approved these changes
Apr 9, 2024
|
Ping @intel/llvm-gatekeepers can this be merged? |
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Apr 18, 2024
Add cubemap support: - Allocation and freeing of cubemapped images - Unsampled fetching and writing, and sampled reading - Device queries for cubemap support - Testing for both unsampled and sampled cubemap examples - Update the spec with cubemap support Remove `const` and `&` qualifiers from spec and implementation for handle parameters in `write_xxx` functions. Corresponding UR PR: oneapi-src/unified-runtime#1433 --------- Co-authored-by: Przemek Malon <[email protected]> Resolved Conflicts in: - Due to not cherry-picking intel#12840 - sycl/include/sycl/detail/pi.h - Due to not cherry-picking intel#13181 - sycl/include/sycl/device_aspect_macros.hpp - sycl/include/sycl/info/aspects.def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cubemap support:
Remove
constand&qualifiers from spec and implementation for handle parameters inwrite_xxxfunctions.Corresponding UR PR: oneapi-src/unified-runtime#1433