[SYCL][Bindless][E2E] fix unsampled images test failure #13007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the test to initialize the input vectors with 0s to match bindless_helpers::fill_rand requirement of non empty vector. * change the name and move init_vector to bindless_helpers.
DBDuncan
approved these changes
Mar 15, 2024
przemektmalon
approved these changes
Mar 18, 2024
isaacault
approved these changes
Mar 19, 2024
Seanst98
suggested changes
Mar 20, 2024
isaacault
suggested changes
Mar 20, 2024
|
@isaacault I updated the description as advised. |
DBDuncan
approved these changes
Mar 21, 2024
isaacault
suggested changes
Mar 22, 2024
isaacault
approved these changes
Mar 25, 2024
Seanst98
approved these changes
Mar 28, 2024
|
@intel/llvm-gatekeepers can you merge this? thanks |
kbenzie
pushed a commit
to kbenzie/intel-llvm
that referenced
this pull request
Apr 18, 2024
* Update the test to initialize the input vectors with 0s to match `bindless_helpers::fill_rand` requirement of non empty vector. * Change the name of function `initVector` to `init_vector`. * move `init_vector`, `equal_vec` and `operator<<` in header `bindless_helpers.hpp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindless_helpers::fill_randrequirement of non empty vector.initVectortoinit_vector.init_vector,equal_vecandoperator<<in headerbindless_helpers.hpp.