Skip to content

[SYCL][Graph][HIP] Set minimum ROCm version for graphs #13035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

EwanC
Copy link
Contributor

@EwanC EwanC commented Mar 15, 2024

Tests UR PR oneapi-src/unified-runtime#1447 that only reports support for UR command-buffers on ROCm 5.5.1 and later to work around HIP driver bugs related to HIP-Graph in earlier version.

This requirement is also explicitly mentioned in the design doc.

@EwanC EwanC temporarily deployed to WindowsCILock March 15, 2024 10:52 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 15, 2024 11:20 — with GitHub Actions Inactive
@EwanC EwanC force-pushed the ewan/graph_rocm_ver branch from 0d1f318 to 14c0343 Compare March 19, 2024 09:44
@EwanC EwanC temporarily deployed to WindowsCILock March 19, 2024 09:45 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 19, 2024 10:04 — with GitHub Actions Inactive
@EwanC EwanC marked this pull request as ready for review March 19, 2024 10:52
@EwanC EwanC requested review from a team as code owners March 19, 2024 10:52
@EwanC EwanC force-pushed the ewan/graph_rocm_ver branch from 14c0343 to c54779a Compare March 20, 2024 10:03
@EwanC EwanC temporarily deployed to WindowsCILock March 20, 2024 10:04 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 20, 2024 10:35 — with GitHub Actions Inactive
Tests UR PR oneapi-src/unified-runtime#1447
that only reports support for UR command-buffers on ROCm
5.5.1 and later to work around HIP driver bugs related to HIP-Graph
in earlier version.

This requirement is also explicitly mentioned in the design doc.
@EwanC EwanC force-pushed the ewan/graph_rocm_ver branch from c54779a to c1b4d1f Compare March 21, 2024 07:58
@EwanC EwanC temporarily deployed to WindowsCILock March 21, 2024 07:58 — with GitHub Actions Inactive
@EwanC EwanC temporarily deployed to WindowsCILock March 21, 2024 08:17 — with GitHub Actions Inactive
@aarongreig
Copy link
Contributor

@intel/llvm-gatekeepers please merge

@martygrant martygrant merged commit 7c70e59 into intel:sycl Mar 21, 2024
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Apr 16, 2024
Tests UR PR oneapi-src/unified-runtime#1447 that
only reports support for UR command-buffers on ROCm 5.5.1 and later to
work around HIP driver bugs related to HIP-Graph in earlier version.

This requirement is also explicitly mentioned in the design doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants