Skip to content

[clang][NFC] Regroup Sema SYCL declarations #13099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2024
Merged

[clang][NFC] Regroup Sema SYCL declarations #13099

merged 1 commit into from
Mar 21, 2024

Conversation

mikerice1969
Copy link
Contributor

In ac74d9e declarations in Sema.h were regrouped by file. This change moves the SYCL code into the correct section.

@mikerice1969
[clang][NFC] Regroup Sema SYCL declarations
38a3457 
In ac74d9e declarations in Sema.h
were regrouped by file. This change moves the SYCL code into the
correct section.
@mikerice1969 mikerice1969 requested a review from a team as a code owner March 21, 2024 20:21
@mikerice1969 mikerice1969 requested a review from jyu2-git March 21, 2024 20:22
jyu2-git
jyu2-git approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jyu2-git jyu2-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Mike!

premanandrao
premanandrao approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikerice1969

smanna12
smanna12 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikerice1969

@mikerice1969
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers, please merge.

@bader bader merged commit 4ca6aac into intel:sycl Mar 21, 2024
@mikerice1969 mikerice1969 deleted the fix-Sema-h-merge branch March 22, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

@smanna12 smanna12 smanna12 approved these changes

@jyu2-git jyu2-git jyu2-git approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikerice1969 @premanandrao @elizabethandrews @smanna12 @jyu2-git @bader