-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL][NATIVECPU] Threadpool implementation for Native CPU #13176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedolinsky
approved these changes
Apr 2, 2024
kbenzie
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the UR repo/tag as suggested.
Comment on lines
145
to
152
"https://github.com/PietroGhg/unified-runtime.git" | ||
# commit e2b5b7fafa8721bfcd46426623adc2b586bacf56 | ||
# Merge: cda0cd94 d05476f4 | ||
# Author: Kenneth Benzie (Benie) <[email protected]> | ||
# Date: Wed Apr 10 14:22:28 2024 +0100 | ||
# Merge pull request #1345 from lplewa/native_cpu_log | ||
# Refactor native cpu adapter to new logger | ||
e2b5b7fafa8721bfcd46426623adc2b586bacf56 | ||
pietro/vecz_threadpool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"https://github.com/PietroGhg/unified-runtime.git" | |
# commit e2b5b7fafa8721bfcd46426623adc2b586bacf56 | |
# Merge: cda0cd94 d05476f4 | |
# Author: Kenneth Benzie (Benie) <[email protected]> | |
# Date: Wed Apr 10 14:22:28 2024 +0100 | |
# Merge pull request #1345 from lplewa/native_cpu_log | |
# Refactor native cpu adapter to new logger | |
e2b5b7fafa8721bfcd46426623adc2b586bacf56 | |
pietro/vecz_threadpool | |
${UNIFIED_RUNTIME_REPO} | |
# commit 38e9478b8a7a01fcf37f55b50c735ca1de29c76d | |
# Merge: b582fb80 c594cdc0 | |
# Author: Kenneth Benzie (Benie) <[email protected]> | |
# Date: Thu Apr 11 11:39:02 2024 +0100 | |
# Merge pull request #1478 from PietroGhg/pietro/vecz_threadpool | |
# [NATIVECPU] Initial threadpool implementation for Native CPU | |
38e9478b8a7a01fcf37f55b50c735ca1de29c76d |
kbenzie
approved these changes
Apr 11, 2024
Hi @intel/llvm-gatekeepers, this looks ready to be merged, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing PR for oneapi-src/unified-runtime#1478.