[SYCL][Graph] in-order queue barrier fix #13193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for intel#13066 The special case for using barriers on an in-order queue is that the last event/node submitted to the queue is used as an event for the barrier to depend on. Looking at the last command submitted to the queue isn't correct for a graph, because previous commands submitted to a graph could have been added explicitly or from recording another queue. Therefore, there is not guaranteed that the last command submitted by the in-order queue is correct dependency for the barrier node in the graph.
|
The |
fabiomestre
reviewed
Mar 29, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
ori-sky
suggested changes
Mar 29, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
fabiomestre
approved these changes
Mar 29, 2024
ori-sky
approved these changes
Mar 29, 2024
Co-authored-by: Ori Sky <[email protected]>
cperkinsintel
approved these changes
Mar 29, 2024
fabiomestre
approved these changes
Apr 1, 2024
|
@intel/llvm-gatekeepers Can you merge this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #13066
The special case for using barriers on an in-order queue is that the last event/node submitted to the queue is used as an event for the barrier to depend on.
Looking at the last command submitted to the queue isn't correct for a graph, because previous commands
submitted to a graph could have been added explicitly or from recording another queue. Therefore, there is not guaranteed that the last command submitted by the in-order queue is correct dependency for the barrier node in the graph.