Skip to content

Fix a build failure shown in HIP backend in multi_ptr_null_relational_operators.cpp test #13268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented Apr 3, 2024

  • change sycl::id<1> to sycl::nd_item<1> in a parallel_for with sycl::nd_range, which caused a build error in HIP backend.

@mmoadeli mmoadeli requested a review from a team as a code owner April 3, 2024 15:04
@mmoadeli mmoadeli requested a review from maarquitos14 April 3, 2024 15:04
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM.

@AlexeySachkov
Copy link
Contributor

Wonder how did pre-commit pass in the first place

@mmoadeli
Copy link
Contributor Author

mmoadeli commented Apr 3, 2024

Wonder how did pre-commit pass in the first place

Yes, a bit odd. I had impression that the failing check was added recently.

@aelovikov-intel
Copy link
Contributor

Yes, a bit odd. I had impression that the failing check was added recently.

Yes, the change was merged in yesterday in #13198.

@ldrumm ldrumm merged commit edafb97 into intel:sycl Apr 3, 2024
@mmoadeli mmoadeli deleted the fix-test branch April 3, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants