[SYCL] Remove ESIMD Emulator #13295
Merged
[SYCL] Remove ESIMD Emulator #13295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
added
the
abi-break
aelovikov-intel
force-pushed
the
remove-esimd-emu
branch
from
a0a677d to
a50ff94
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
commented
Apr 5, 2024
Comment on lines
+24
to
+25
| // No support anymore: | ||
| // ext_intel_esimd_emulator = 5, |
There was a problem hiding this comment.
I don't know if we should preserve this space in numbering or decrease value for hip/native_cpu by one. Same question for a few other enums.
@sergey-semenov , @steffenlarsen , @AlexeySachkov , WDYT?
There was a problem hiding this comment.
I guess that values of most (or all) of those enumerations are not user-visible in context that there are no specification which documents exact values. Having gaps in them won't increase size of variables of those enumeration types, because underlying types would still be the same. Therefore, I would vote for leaving the gaps in, simply to reduce amount of things we are breaking.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
approved these changes
Apr 8, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@maarquitos14 , @intel/llvm-reviewers-runtime , ping. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Jul 18, 2024
This function is not called anywhere from SYCL headers and therefore there is no reason to have it exported. It was made exported as part of ESIMD emulator plugin addition (intel#2963), but that plugin was since then deprecated and removed (intel#13295).
AlexeySachkov
added a commit
that referenced
this pull request
Jul 18, 2024
This function is not called anywhere from SYCL headers and therefore there is no reason to have it exported. It was made exported as part of ESIMD emulator plugin addition (#2963), but that plugin was since then deprecated and removed (#13295). This is patch is essentially a by-product of #14145 and it is done to simplify that change, i.e. PI plugins removal should not be ABI-breaking by itself, we just need to cleanup some of our exported symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.