Skip to content

Revert "[ABI-Break][SYCL] Remove collectives in the sub-group class" #13464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2024
Merged

Revert "[ABI-Break][SYCL] Remove collectives in the sub-group class" #13464

merged 1 commit into from
Apr 18, 2024

Conversation

aelovikov-intel
Copy link
Contributor

Reverts #13199

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner April 17, 2024 23:32
@aelovikov-intel
Copy link
Contributor Author

Some people are still using these and asking for more time to fix their code.

@aelovikov-intel
Copy link
Contributor Author

This would need to go after #13463.

@aelovikov-intel aelovikov-intel merged commit cb2eede into sycl Apr 18, 2024
20 of 22 checks passed
@aelovikov-intel aelovikov-intel deleted the revert-13199-abi-sg-collectives branch April 18, 2024 22:10
@aelovikov-intel aelovikov-intel mentioned this pull request May 6, 2024
Merged
aelovikov-intel added a commit that referenced this pull request Jun 27, 2024
@aelovikov-intel
[ABI-Break][SYCL] Remove collectives in the sub-group class (#13665)
7193c26 
Re-lands #13199 and reverts
#13464.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@stdale-intel stdale-intel Awaiting requested review from stdale-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelovikov-intel @sergey-semenov