Skip to content

[Doc] Add Mar'24 Release Notes #13879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 6, 2024

Conversation

uditagarwal97
Copy link
Contributor

No description provided.

Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that we had more changes for the release.
I've compiled a list of ~500 commits which are not UR uplifts, test fixes or CI tweaks, but I can't say for sure if something is missing from this PR without a more detailed comparison, because some changes were reverted, some are related to the same feature and can be merged, etc.


### SYCL Library
- Fixed computation of submit time based on host timestamps. [254756369c]
- Fixed SYCL CTS failures for Unified Runtime's OpenCL adapter. [4c0780e76]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will @aarongreig here, but it seems to me that all those fixes were a part of Unified Runtime, and not a part of SYCL RT for which this release notes are.

Considering that Unified Runtime is an external dependency, I wonder if we need to include a separate sub-section here to specify which version/hash/tag of Unified Runtime should be used together with that release - users will then be able to go and look for release notes of that version in the UR repo, or browse history of changes. Tagging @againull, @steffenlarsen and @nrspruit here for their feedback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of having a sub-section to specify the UR tag.

@uditagarwal97 uditagarwal97 marked this pull request as ready for review May 23, 2024 12:26
@uditagarwal97 uditagarwal97 requested review from tfzhu and a team as code owners May 23, 2024 12:26
@uditagarwal97
Copy link
Contributor Author

I thought that we had more changes for the release. I've compiled a list of ~500 commits which are not UR uplifts, test fixes or CI tweaks, but I can't say for sure if something is missing from this PR without a more detailed comparison, because some changes were reverted, some are related to the same feature and can be merged, etc.

Could you share your list of commits? I've prepared a list myself, so I can do a quick comparison to make sure nothing is missing. Also, I've intentionally not included some refactoring-related changes and NFCs, that have negligible end-user exposure.

@uditagarwal97 uditagarwal97 self-assigned this May 28, 2024
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uditagarwal97
Copy link
Contributor Author

@AlexeySachkov @tfzhu friendly ping!

@uditagarwal97
Copy link
Contributor Author

@intel/llvm-gatekeepers the PR is ready!

@aelovikov-intel aelovikov-intel merged commit b8693eb into intel:sycl Jun 6, 2024
2 checks passed
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants