-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL] Allow raw pointers in SYCL vec load and store #13895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Allow raw pointers in SYCL vec load and store #13895
Conversation
In accordance with KhronosGroup/SYCL-Docs#555 proposal, this commit allows raw pointers in the `load` and `store` member functions on `sycl::vec`. Signed-off-by: Larsen, Steffen <[email protected]>
KhronosGroup/SYCL-Docs#555 has been merged, so this is ready for review. |
Signed-off-by: Larsen, Steffen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a few nits regarding LLVM commenting guidelines.
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for making the changes!
In accordance with KhronosGroup/SYCL-Docs#555 proposal, this commit allows raw pointers in the
load
andstore
member functions onsycl::vec
.