Skip to content

[SYCL] Allow raw pointers in SYCL vec load and store #13895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

steffenlarsen
Copy link
Contributor

In accordance with KhronosGroup/SYCL-Docs#555 proposal, this commit allows raw pointers in the load and store member functions on sycl::vec.

In accordance with KhronosGroup/SYCL-Docs#555
proposal, this commit allows raw pointers in the `load` and `store`
member functions on `sycl::vec`.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen
Copy link
Contributor Author

KhronosGroup/SYCL-Docs#555 has been merged, so this is ready for review.

@steffenlarsen steffenlarsen marked this pull request as ready for review June 26, 2024 06:01
@steffenlarsen steffenlarsen requested a review from a team as a code owner June 26, 2024 06:01
Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a few nits regarding LLVM commenting guidelines.

Signed-off-by: Larsen, Steffen <[email protected]>
Signed-off-by: Larsen, Steffen <[email protected]>
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes!

@steffenlarsen steffenlarsen merged commit f5178eb into intel:sycl Jun 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants