Skip to content

[SYCL][TEST-E2E] Disallow dep_events.cpp test built for CUDA backend to run on Windows #13957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

mmoadeli
Copy link
Contributor

@mmoadeli mmoadeli commented May 29, 2024

Windows doesn't support cudaMemPrefetchAsync() which is used in the call to prefetch in the test.
urEnqueueUSMPrefetch is also commented with a note for not having the support for CUDA on Windows.

@mmoadeli mmoadeli requested a review from a team as a code owner May 29, 2024 17:40
@mmoadeli mmoadeli requested a review from dm-vodopyanov May 29, 2024 17:40
@mmoadeli mmoadeli temporarily deployed to WindowsCILock May 29, 2024 18:24 — with GitHub Actions Inactive
@mmoadeli mmoadeli temporarily deployed to WindowsCILock May 29, 2024 19:15 — with GitHub Actions Inactive
@mmoadeli mmoadeli requested a review from steffenlarsen June 3, 2024 08:17
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fairly basic test. Do we have a UR issue for investigating alternatives for Windows?

@mmoadeli
Copy link
Contributor Author

mmoadeli commented Jun 3, 2024

investigating alternatives for Windows

@steffenlarsen
I created one. oneapi-src/unified-runtime#1700

@steffenlarsen
Copy link
Contributor

Failure in ProfilingTag/in_order_queue.cpp seems to be the same as #14053. I will disable all profiling tag tests on CUDA in a separate patch.

@steffenlarsen steffenlarsen merged commit 2de1435 into intel:sycl Jun 6, 2024
13 of 14 checks passed
@mmoadeli mmoadeli deleted the windows-cuda-disable-prefetch branch June 6, 2024 10:25
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
…d to run on Windows (intel#13957)

[Windows doesn't support
cudaMemPrefetchAsync()](bitsandbytes-foundation/bitsandbytes#453)
which is used in the call to `prefetch` in the test.

[urEnqueueUSMPrefetch](https://github.com/oneapi-src/unified-runtime/blob/c0c607c3a88933b4c5c20a0aca4539781c678411/source/adapters/cuda/enqueue.cpp#L1629)
is also commented with a note for not having the support for CUDA on
Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants