[ESIMD] Allow full autodeduction of template parameters for atomic_update USM API accepting simd_view #14043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API accepting simd_view
sarnex
reviewed
Jun 6, 2024
| @@ -9400,16 +9429,61 @@ atomic_update(T *p, simd<Toffset, N> byte_offset, simd<T, N> src0, | |||
|
|
|||
| /// simd<T, N> | |||
| /// atomic_update(T *ptr, simd<Toffset, N> byte_offset, | |||
| /// simd<T, N> src0, props = {}); // (usm-au1-2) | |||
There was a problem hiding this comment.
Looks like we lost the // (usm-au1-2) comment, is that intentional?
There was a problem hiding this comment.
nvm i see, the diff is just confusing
sarnex
approved these changes
Jun 6, 2024
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
…date USM API accepting simd_view (intel#14043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.