Skip to content

[SYCL][E2E] Fix deprecated warnings in Regression e2e tests #14168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 28, 2024

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jun 13, 2024

No description provided.

@ayylol ayylol requested a review from a team as a code owner June 13, 2024 17:55
@ayylol ayylol requested a review from maarquitos14 June 13, 2024 17:55
@ayylol ayylol marked this pull request as draft June 13, 2024 18:17
@@ -76,8 +76,7 @@ int main(int argc, char *argv[]) {
std::vector<sycl::device> dlist;
if (gpu_dev == 999) {
try {
auto sel = sycl::gpu_selector();
sel_dev = sel.select_device();
sel_dev = sycl::device(sycl::gpu_selector_v);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't do much given

// RUN: %clangxx -fsycl -fsycl-targets=%{sycl_triple} %S/Inputs/FindPrimesSYCL.cpp %S/Inputs/main.cpp -o %t.out -lpthread
. I think we should either use implicit default selector in this file or adjust the other file to maybe use %{run-unfiltered-devices}.

@ayylol ayylol temporarily deployed to WindowsCILock June 24, 2024 22:38 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock June 24, 2024 22:50 — with GitHub Actions Inactive
@ayylol ayylol marked this pull request as ready for review June 27, 2024 21:17
@ayylol ayylol temporarily deployed to WindowsCILock June 27, 2024 22:22 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock June 28, 2024 00:35 — with GitHub Actions Inactive
@againull againull merged commit b51ebb8 into intel:sycl Jun 28, 2024
13 checks passed
@ayylol ayylol deleted the e2e-regression branch June 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants