[SYCL] Move non device code checks outside of check_device_code #14175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldrumm Friendly ping, thank you! |
|
@intel/sycl-matrix-reviewers Friendly ping: just a quick change anyway. Thanks in advance! |
|
@intel/llvm-gatekeepers This PR is ready, thank you! |
|
@intel/llvm-gatekeepers Friendly ping, thanks! |
aelovikov-intel
pushed a commit
that referenced
this pull request
Jul 8, 2024
) It would appear that I missed a file in #14175. I looked over the files again and did not catch anything else, but do let me know if there is more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same vein as #14174, this PR moves test cases that do not check device code outside of the
check_device_codefolder. This is a separate PR as #14174 because the code is technically owned by another team.