[SYCL] Add sorting APIs for fixed-size private array input #14185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tag @andreyfe1 |
PR doesn't include key/value sorting with fixed-size array input which will be added in a separate PR.
againull
force-pushed
the
feature/array_sort_with_props
branch
from
a485b0e to
28c732d
Compare
Co-authored-by: Dmitry Vodopyanov <[email protected]>
|
LGTM, @andreyfe1 can you please review? |
andreyfe1
reviewed
Jun 19, 2024
sycl/include/sycl/ext/oneapi/experimental/group_helpers_sorters.hpp
Outdated
Show resolved
Hide resolved
dm-vodopyanov
approved these changes
Jun 19, 2024
andreyfe1
reviewed
Jun 21, 2024
|
|
||
| template <group_algorithm_data_placement Placement> | ||
| inline constexpr output_data_placement_key::value_t<Placement> | ||
| output_data_placement; |
There was a problem hiding this comment.
We still have output_data_placement_key and input_data_placement_key in namespace sycl::ext::oneapi::experimental.
Is it expected? What to do with that?
There was a problem hiding this comment.
This is expected, those ones are necessary for kernel properties functionality to work.
There was a problem hiding this comment.
So, we need to change the Spec accordingly, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR covers (1), (2), (3) from https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc#functions-with-fixed-size-arrays.
PR doesn't include key/value sorting with fixed-size array input which will be added in a separate PR.