[SYCL][Graph] Fix queue recording barrier to different graphs #14212
+92
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 18, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. Depends on PR intel#14212
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 18, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. Depends on PR intel#14212
Recording barrier submissions to from the same queue to a different graph current produces the following error with added regression tests: ``` Terminate called after throwing an instance of 'sycl::_V1::exception' what(): Graph nodes cannot depend on events from another graph. ``` This is because the queue implementation doesn't clear all the state around what the last queue submission was between graph recordings. Fixed by clearing all members of the barrier book keeping struct in the queue.
EwanC
force-pushed
the
ewan/barrier_multi_graph
branch
from
7b85fb2 to
9c8002d
Compare
EwanC
added a commit
to reble/llvm
that referenced
this pull request
Jun 19, 2024
In order to enable the minimum viable real life usecase for the Whole Graph Update feature. Allow graphs to contain empty nodes and barrier nodes during update. Depends on PR intel#14212
Bensuo
approved these changes
Jun 19, 2024
|
tagging @intel/llvm-reviewers-runtime for review (assigned reviewer status is off sick) |
uditagarwal97
approved these changes
Jun 19, 2024
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording barrier submissions to from the same queue to a different graph current produces the following error with added regression test:
This is because the queue implementation doesn't clear all the state around what the last queue submission was between graph recordings.
Fixed by clearing all members of the barrier book keeping struct in the queue.