[SYCL] Switch to preview implementation of sycl::vec
#14317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
added
the
abi-break
This comment was marked as outdated.
This comment was marked as outdated.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
abi-vec-impl
branch
from
e5ccd59 to
325d9c2
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
abi-vec-impl
branch
from
325d9c2 to
519e114
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
abi-vec-impl
branch
from
519e114 to
24e2b8a
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
commented
Jul 15, 2024
| @@ -1429,8 +1429,7 @@ class SwizzleOp { | |||
| DataT getValue(EnableIfMultipleIndexes<IdxNum, size_t> Index) const { | |||
| if (std::is_same_v<OperationCurrentT<DataT>, GetOp<DataT>>) { | |||
| std::array<int, getNumElements()> Idxs{Indexes...}; | |||
| // Cast required for int8_t -> std::byte | |||
| return static_cast<DataT>(m_Vector->getValue(Idxs[Index])); | |||
| return (*m_Vector)[Idxs[Index]]; | |||
There was a problem hiding this comment.
This is the bugfix mentioned in the description.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
CUDA testing succeeded in https://github.com/intel/llvm/actions/runs/9963598138, re-run was triggered by re-run of the AMDGPU task that was necessary due to the infrastructure issues on the runner (GPU not visible). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm keeping the
vector_preview.hppfile name to avoid misleading diff in this PR.Also, a minor fix in swizzles implementation is included in this change fixing a bug that would have affected
SubGroup/load_store.cppE2E test otherwise.