Skip to content

[SYCL] Fix postcommit #14373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[SYCL] Fix postcommit #14373

merged 1 commit into from
Jul 1, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jul 1, 2024

Totally broken on all platforms right now.

/__w/llvm/llvm/src/sycl/source/detail/physical_mem_impl.hpp:33:3: error: default label in switch which covers all enumeration values [-Werror,-Wcovered-switch-default]
   33 |   default:

and

#14372

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex requested review from a team as code owners July 1, 2024 19:36
@sarnex sarnex requested a review from dm-vodopyanov July 1, 2024 19:36
@sarnex
Copy link
Contributor Author

sarnex commented Jul 1, 2024

Merging now to unbreak CI.

@steffenlarsen FYI

@sarnex sarnex merged commit 92c9f01 into intel:sycl Jul 1, 2024
5 of 7 checks passed
@bader
Copy link
Contributor

bader commented Jul 1, 2024

@sarnex, pre-commit has failed. I would wait pre-commit results before merging.

@sarnex
Copy link
Contributor Author

sarnex commented Jul 1, 2024

 /__w/llvm/llvm/src/sycl/source/detail/physical_mem_impl.hpp:34:1: error: control reaches end of non-void function [-Werror=return-type]

sigh

@aelovikov-intel
Copy link
Contributor

@sarnex, pre-commit has failed. I would wait pre-commit results before merging.

That's not feasible because pre-commit runs take many hours to finish...

@sarnex
Copy link
Contributor Author

sarnex commented Jul 1, 2024

Yeah my bad on this one. I'll fix it and try to run precommit when I can but for high priority issues like this there is always some risk/reward tradeoff.

@bader
Copy link
Contributor

bader commented Jul 1, 2024

Yeah my bad on this one. I'll fix it and try to run precommit when I can but for high priority issues like this there is always some risk/reward traceoff.

I don't think "high priority issue" justifies the risk. We have fixes for high priority issues every day.

Do you mean: we need to merge some change urgently? Could you clarify what the reason for the urgency with this PR? Failing tests in post-commit does not sound to me as a good reason to take the risk to break pre-commit testing.

The much less risky change would be reverting the commit breaking post-commit validation. But even revert commit must pass pre-commit testing.

@sarnex
Copy link
Contributor Author

sarnex commented Jul 1, 2024

Could you clarify what the reason for the urgency with this PR?

Postcommit build on multiple platforms was failing, and a developer reached out to me internally telling me about the problem and that they would like this fixed asap. In general if I wasn't confident on the fix and it being trivial I would just revert, but my confidence was incorrect in this case, and that was my bad.

sarnex added a commit that referenced this pull request Jul 1, 2024
Fixes precommit after unsuccessful post-commit fix at
#14373.

Signed-off-by: Nick Sarnie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants