-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Fix postcommit #14373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Fix postcommit #14373
Conversation
Signed-off-by: Sarnie, Nick <[email protected]>
Merging now to unbreak CI. @steffenlarsen FYI |
@sarnex, pre-commit has failed. I would wait pre-commit results before merging. |
sigh |
That's not feasible because pre-commit runs take many hours to finish... |
Yeah my bad on this one. I'll fix it and try to run precommit when I can but for high priority issues like this there is always some risk/reward tradeoff. |
I don't think "high priority issue" justifies the risk. We have fixes for high priority issues every day. Do you mean: we need to merge some change urgently? Could you clarify what the reason for the urgency with this PR? Failing tests in post-commit does not sound to me as a good reason to take the risk to break pre-commit testing. The much less risky change would be reverting the commit breaking post-commit validation. But even revert commit must pass pre-commit testing. |
Postcommit build on multiple platforms was failing, and a developer reached out to me internally telling me about the problem and that they would like this fixed asap. In general if I wasn't confident on the fix and it being trivial I would just revert, but my confidence was incorrect in this case, and that was my bad. |
Fixes precommit after unsuccessful post-commit fix at #14373. Signed-off-by: Nick Sarnie <[email protected]>
Totally broken on all platforms right now.
and
#14372