Skip to content

[SYCL][Bindless] Update spirv read/fetch from sampled image and sampled image array #14493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2024
Merged

[SYCL][Bindless] Update spirv read/fetch from sampled image and sampled image array #14493

merged 2 commits into from
Jul 9, 2024

Conversation

wenju-he
Copy link
Contributor

@wenju-he wenju-he commented Jul 9, 2024

For spirv path, call __invoke__ImageReadLod to generate image builtin represented as ImageSampleExplicitLod instruction in SPIRV that can be consumed by Intel Graphics Compiler.

@wenju-he
[SYCL][Bindless] Update spirv read/fetch from sampled image and sampl…
85a5373 
…ed image array

For spirv path, call __invoke__ImageReadLod to generate image builtin
represented as ImageSampleExplicitLod instruction in SPIRV that can be
consumed by Intel Graphics Compiler.
@wenju-he wenju-he requested a review from a team as a code owner July 9, 2024 06:10
@wenju-he wenju-he temporarily deployed to WindowsCILock July 9, 2024 06:37 — with GitHub Actions Inactive
@wenju-he wenju-he requested a review from a team as a code owner July 9, 2024 07:47
@wenju-he wenju-he requested a review from aelovikov-intel July 9, 2024 07:47
@wenju-he wenju-he temporarily deployed to WindowsCILock July 9, 2024 07:47 — with GitHub Actions Inactive
@wenju-he wenju-he temporarily deployed to WindowsCILock July 9, 2024 08:19 — with GitHub Actions Inactive
isaacault
isaacault approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@isaacault isaacault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

aelovikov-intel
aelovikov-intel approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both files should be owned by @intel/bindless-images-reviewers and @intel/llvm-reviewers-runtime 's approval shouldn't be necessary here. Please submit another PR changing CODEOWNERS accordingly.

aelovikov-intel
aelovikov-intel approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both files should be owned by @intel/bindless-images-reviewers and @intel/llvm-reviewers-runtime 's approval shouldn't be necessary here. Please submit another PR changing CODEOWNERS accordingly.

@aelovikov-intel aelovikov-intel merged commit a14c091 into intel:sycl Jul 9, 2024
14 checks passed
@wenju-he wenju-he deleted the __invoke__ImageReadLod branch July 10, 2024 01:08
@wenju-he wenju-he mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacault isaacault isaacault approved these changes

@DBDuncan DBDuncan DBDuncan approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenju-he @isaacault @DBDuncan @aelovikov-intel