[SYCL] Add AMDGPU_kernel calling convention to detected kernels #14581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Change looks good. Will it be reasonable to add a unit test for this? Thanks |
omarahmed1111
force-pushed
the
fix-free-function-kernels-test-on-hip
branch
2 times, most recently
from
fcbfdec to
bd49a51
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
force-pushed
the
fix-free-function-kernels-test-on-hip
branch
from
bd49a51 to
7599fa9
Compare
omarahmed1111
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
omarahmed1111
force-pushed
the
fix-free-function-kernels-test-on-hip
branch
from
7599fa9 to
df753f2
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sry for late, I updated that with a unittest |
omarahmed1111
force-pushed
the
fix-free-function-kernels-test-on-hip
branch
from
df753f2 to
1995c50
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
force-pushed
the
fix-free-function-kernels-test-on-hip
branch
from
1995c50 to
58f300c
Compare
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Aug 10, 2024
AlexeySachkov
approved these changes
Aug 10, 2024
|
@omarahmed1111, please, add [SYCL] tag to the PR title. |
omarahmed1111
changed the title
|
@intel/llvm-gatekeepers Please merge when possible, Thanks! |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
…l#14581) `free_function_kernels.cpp` test had a bug where the kernels with demangled name for free functions will be deleted in the `sycl-post-link` step of compilation. And this happened as AMD kernels was not detected due to a missing condition. This was not detected before as the HIP device on CI doesn't have `usm_shared_allocations` aspect available so it was detected as unsupported but when I tried it locally with a device with `usm_shared_allocations` aspect available, the test was failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
free_function_kernels.cpptest had a bug where the kernels with demangled name for free functions will be deleted in thesycl-post-linkstep of compilation. And this happened as AMD kernels was not detected due to a missing condition. This was not detected before as the HIP device on CI doesn't haveusm_shared_allocationsaspect available so it was detected as unsupported but when I tried it locally with a device withusm_shared_allocationsaspect available, the test was failing.