[syclcompat][E2E] Skip case in math_vectorized_isgreater_test if fp16 unsupported #14596
Conversation
… unsupported The second test case in sycl/test-e2e/syclcompat/math/math_vectorized_isgreater_test.cpp uses vector of sycl::half, which requires devices to support aspect::fp16. This commit makes the test skip this case if the device does not support the aspect. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@steffenlarsen #14594 addressed this issue (though it was really disabling the test for that case). We are happy with both solutions, though yours seems better. |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
My bad, @Alcpz ! Alternatively, we can also split the test, making the aspect requirement in the one using half. The reason I went for a skip of only part was to still cover the supported case, but we could do that with a split as well. Either way, we can probably make it a follow-up if that is the way we want to go. |
|
No problem, Thanks for the contribution! I think this skip is good, it's a relatively simple test and creating a whole new test case for the split seems too much. |
The second test case in sycl/test-e2e/syclcompat/math/math_vectorized_isgreater_test.cpp uses vector of sycl::half, which requires devices to support aspect::fp16. This commit makes the test skip this case if the device does not support the aspect.